docs(start/tutorial): remove unnecessary useEffect
#9561
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using useEffect for syncing state with props (or other external state) is unnecessary, and can trigger additional renders and potentially flashes of incorrect content. We can use a useState to detect changes in order to trigger a sync.
This is explicitly allowed by React – https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes
While an in-depth tutorial of React is out of scope for Remix's tutorial, it remains the case that people look to projects like Remix for good examples – we ought to avoid effects where they aren't necessary (and are explicitly discouraged).