Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(start/quickstart): add future Vite compatibility #9667

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ezekeal
Copy link

@ezekeal ezekeal commented Jun 27, 2024

Current versions of vite warn that esmodule support is required for future versions. Moving this step earlier will avoid confusion.

Closes: #

  • Docs
  • Tests

Testing Strategy:

Current versions of vite warn that esmodule support is required for future versions. Moving this step earlier will avoid confusion.
Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 5bef794

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 27, 2024

Hi @ezekeal,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@ezekeal ezekeal marked this pull request as draft June 27, 2024 19:41
Current versions of vite warn that esmodule support is required for future versions. Moving this step earlier will avoid confusion.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 27, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@ezekeal ezekeal marked this pull request as ready for review June 27, 2024 19:45
@MichaelDeBoey MichaelDeBoey changed the title Update quickstart.md for future vite compatibility docs(start/quickstart): add future Vite compatibility Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants