Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to change global dev server hooks key value #9931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mordred
Copy link

@Mordred Mordred commented Sep 2, 2024

Closes: #9780

This change allows developers to specify where the global dev server hooks are stored so that we can avoid conflicts when running multiple instances per one express app.

Example of usage:

// vite.config.js
import { vitePlugin as remix } from "@remix-run/dev";
import { defineConfig } from "vite";

export default defineConfig({
  plugins: [remix({
    devServerHooksKey: '__remix_devServerHooks_admin'
  })],
});
// somewhere in your express server
app.all(
  "/admin/*",
  createRequestHandler({
    build: adminBuild,
    devServerHooksKey: '__remix_devServerHooks_admin'
  })
);

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 1bf75f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
@remix-run/express Patch
@remix-run/server-runtime Patch
@remix-run/serve Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 2, 2024

Hi @Mordred,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@Mordred Mordred force-pushed the feature/global-hook-key-override branch from 780470b to 1bf75f4 Compare September 2, 2024 07:03
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 2, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple remix dev servers in one express application
2 participants