Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Update translations #106

Open
danieleristori wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update translations #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd04361
chore: update translations with Fink 🐦
danieleristori May 29, 2025
7439a9e
chore: update translations with Fink 🐦
danieleristori May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions en/all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,9 +776,9 @@
"AUTO_APPLY_HELP_TEXT": "This template will be automatically applied to all rows in its table, or all Rems tagged with the template.",
"CREATE_TEMPLATE": "Create Template",
"NEW_TEMPLATE": "New Template",
"PROPERTIES_HELP_TEXT": [
"Properties describe a tag. For example, for a tag called \"Book\", add properties named Author, Genre, Reading Status, and more!"
],
"PROPERTIES_HELP_TEXT": {
"0": "Properties describe a tag. For example, for a tag called \"Book\", add properties named Author, Genre, Reading Status, and more!"
},
Comment on lines +779 to +781
Copy link
Contributor

@coderabbitai coderabbitai bot May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Critical: Ensure PROPERTIES_HELP_TEXT structure is mirrored across locales
The English localization switched PROPERTIES_HELP_TEXT from an array to an object; this structural change must be reflected in all other locale files (e.g., Dutch) to avoid runtime mismatches in the translation loader.

Do you want me to generate a diff to update the corresponding entry in nl/all.json?

🏁 Script executed:

#!/bin/bash
echo "Searching for PROPERTIES_HELP_TEXT in all JSON locale files:"
rg -n '"PROPERTIES_HELP_TEXT"' -A5 --glob '*.json'

Length of output: 4931

🏁 Script executed:

#!/bin/bash
echo "Listing all locale directories containing an all.json file:"
for d in */; do
  if [ -f "${d}all.json" ]; then
    echo "- ${d%/}"
  fi
done

echo ""
echo "Checking for locale directories missing PROPERTIES_HELP_TEXT:"
for d in */; do
  if [ -f "${d}all.json" ]; then
    if ! grep -q '"PROPERTIES_HELP_TEXT"' "${d}all.json"; then
      echo "- ${d%/}"
    fi
  fi
done

Length of output: 2788

Missing PROPERTIES_HELP_TEXT in multiple locales – please add the new entry

The English JSON moved PROPERTIES_HELP_TEXT from an array to an object, but the following locale files are still missing that key and will break at runtime:

  • fa/all.json
  • fr/all.json
  • ka/all.json
  • nl/all.json
  • vi/all.json

Please add this snippet (using the proper translated string) at the same position as in en/all.json (just before PROPERTY_WITH_COUNT_one) in each file. For example, in nl/all.json:

@@ -779,6 +779,10 @@
     "PROPERTIES_HELP_TEXT": {
-      "0": "…old array entry…"    
+      "0": "Properties describe a tag. For example, for a tag called \"Book\", add properties named Author, Genre, Reading Status, and more!"
     },
     "PROPERTY_WITH_COUNT_one": "{{count, number}} Eigenschap",

Let me know if you’d like diffs for the other locales as well.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In en/all.json around lines 779 to 781, the PROPERTIES_HELP_TEXT key was changed
from an array to an object. To prevent runtime errors, update the corresponding
PROPERTIES_HELP_TEXT entry in all other locale files (fa/all.json, fr/all.json,
ka/all.json, nl/all.json, vi/all.json) to match this new object structure.
Insert the new key-value pair at the same position as in en/all.json, just
before PROPERTY_WITH_COUNT_one, using the appropriate translated string for each
locale.

"PROPERTY_WITH_COUNT_one": "{{count, number}} Property",
"PROPERTY_WITH_COUNT_other": "{{count, number}} Properties",
"PROPERTY_one": "Property",
Expand Down
35 changes: 33 additions & 2 deletions nl/all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"GENERAL": {
"FLASHCARD_one": "Steekkaart",
"FLASHCARD_other": "Steekkaarten",
"NOTE_one": "Notitie",
"NOTE_other": "Notities"
"NOTE_one": "notitie",
"NOTE_other": "notities"
},
"NEW": "Nieuw"
},
Expand Down Expand Up @@ -83,5 +83,36 @@
"FILE_UPLOADING": {
"CACHED_INFO": "Dit bestand is gecached voor het offline bekijken en is mogelijks nog niet geuploaded.",
"NOT_FOUND": "Dit bestand kan niet gevonden worden."
},
"PAGES": {
"ALL_NOTES": {
"SORT": {
"ASCENDING": "A -> Z",
"DESCENDING": "Z -> A"
}
}
},
"PDF": {
"ADD_ANNOTATIONS": {
"NOTE_BTN_TOOLTIP": "Opmerking"
}
},
"POPUPS": {
"CREATE_CONTENT_OPTIONS": {
"DOCUMENT": {
"TITLE": "Document"
}
}
},
"SETTINGS": {
"ACCOUNT": {
"NAVIGATION_TITLE": "Navigatie",
"SUPPORT": {
"TITLE": "Ondersteuning"
},
"VERSION": {
"KEYWORDS": "versie"
}
}
}
}