fix: cross-platform test failures #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update build.zig for zig 0.15 API (createModule, standardOptimizeOption) - add ghostty-vt dependency for terminal emulation - use -gnu suffix for linux targets to fix PIC linker errors - update CI workflows to use zig 0.15.2 - update all zig source files for 0.15 compatibility
…inux - Update React and Solid workflows to use Zig 0.15.2 (required by ghostty-vt) - Skip macOS targets when building on non-macOS hosts (ghostty's apple-sdk doesn't support cross-compilation from Linux) - Update TypeScript build script to handle missing platform builds gracefully
- Add mitchellh/zig-build-macos-sdk dependency (official SDK used by Ghostty) - Configure SDK paths on module before loading ghostty dependencies - Update to latest ghostty commit - Remove skip logic for macOS targets since SDK is now provided
Native binaries for all platforms are built in the release workflow (build-native.yml on macOS). PR checks only need to build the TypeScript library and run tests.
macOS can cross-compile to all platforms (Linux, Windows, macOS). This avoids the complexity of setting up macOS SDK on Linux runners.
- By default, zig build now only builds for the native platform - Add -Dall option to zig build for building all platforms - Add --all flag to TypeScript build script - Update release workflow to use --all for cross-compilation This allows Linux users to run `bun run build` without failing on macOS targets.
- ArrayList.init(allocator) → ArrayListUnmanaged with allocator per-method - std.fmt.formatIntBuf → std.fmt.bufPrint - std.fmt.formatInt → writer.print - std.zon.parse.Status removed, use fromSlice directly
- Add vterm.zig with ghostty-vt integration for terminal emulation - Add VTerm FFI functions to lib.zig and zig.ts - Add StatelessTerminalRenderable and TerminalRenderable classes - Fix renderer.zig to skip stdout writes in testing mode (fixes hanging tests) - Fix circular dependency by moving VTerm types to lib/vterm-ffi.ts
--------- Co-authored-by: Sebastian <[email protected]>
- TreeSitter cache test: use file path instead of /invalid to ensure mkdir fails on all platforms (root on musl, different path semantics on Windows) - TestRecorder timestamps: make test deterministic with explicit renderOnce calls - Mock mouse drag: fix SGR protocol - drag events should use 'M' (press) not 'm' (release)
There was a problem hiding this comment.
Pull request overview
This PR fixes cross-platform test failures by addressing platform-specific issues in three areas: TreeSitter cache directory validation, TestRecorder timestamp determinism, and mouse drag event protocol compliance.
Key Changes:
- TreeSitter cache test now uses an actual file path instead of
/invalidto ensure mkdir fails consistently - TestRecorder timestamps made deterministic with explicit renderOnce calls
- Mouse drag events fixed to use SGR 'M' (press) instead of 'm' (release)
Reviewed changes
Copilot reviewed 85 out of 86 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vue/src/elements.ts | Added terminal renderable exports |
| packages/solid/tests/textarea.test.tsx | Added measure cache edge case tests with renderOnce calls |
| packages/solid/tests/link.test.tsx | Added link inheritance tests and removed duplicate afterEach |
| packages/solid/package.json | Version bump to 0.1.69 |
| packages/solid/index.ts | Support renderer reuse and proper cleanup |
| packages/solid/examples/index.tsx | Changed default example to terminal-grid-demo |
| packages/solid/examples/components/terminal-grid-demo.tsx | New terminal grid demo component |
| packages/solid/examples/components/ExampleSelector.tsx | Added terminal grid demo option |
| packages/react/src/types/components.ts | Added terminal component type exports |
| packages/react/src/reconciler/renderer.ts | Handle renamed flushSync in react-reconciler 0.32.0 |
| packages/react/src/components/index.ts | Added terminal renderable exports |
| packages/react/package.json | Version bump to 0.1.69 |
| packages/react/examples/flush-sync.tsx | New flushSync example |
| packages/go/README.md | Updated Zig version requirement to 0.15.2+ |
| packages/core/src/zig/vterm.zig | New virtual terminal implementation |
| packages/core/src/zig/utf8.zig | Changed ArrayList to ArrayListUnmanaged for efficiency |
| packages/core/src/zig/text-buffer.zig | Added content epoch tracking and measure cache |
| packages/core/src/zig/text-buffer-view.zig | Improved measure cache with epoch-based invalidation |
| packages/core/src/zig/text-buffer-segment.zig | Fixed wrap offset ownership transfer |
| packages/core/src/zig/tests/* | Updated tests for ArrayListUnmanaged migration |
| packages/core/src/zig/syntax-style.zig | Changed formatInt to print call |
| packages/core/src/zig/rope.zig | ArrayList to ArrayListUnmanaged migration |
| packages/core/src/zig/renderer.zig | BufferedWriter to direct writer with buffer |
| packages/core/src/zig/logger.zig | Changed C callconv to c |
| packages/core/src/zig/lib.zig | Added ghostty log suppression and terminal exports |
| packages/core/src/zig/event-bus.zig | Changed C callconv to c |
| packages/core/src/zig/edit-buffer.zig | Fixed segments deinit call |
| packages/core/src/zig/build.zig.zon | Updated to Zig 0.15.2 and added ghostty dependency |
| packages/core/src/zig/build.zig | Refactored build system for Zig 0.15.2 |
| packages/core/src/zig/buffer.zig | ArrayList to ArrayListUnmanaged migration |
| packages/core/src/zig/bench/* | Benchmark refactoring for ArrayListUnmanaged |
| packages/core/src/renderer.ts | Fixed keyInput getter type assertion |
Comments suppressed due to low confidence (6)
packages/solid/tests/link.test.tsx:1
- The afterEach hook has been removed, but the beforeEach hook still calls testSetup.renderer.destroy() if testSetup exists. This creates an inconsistency in cleanup logic. If cleanup is needed, it should be consistently handled in either beforeEach or afterEach, not removed entirely.
packages/solid/examples/index.tsx:1 - The import statement imports 'terminal-grid-demo' but assigns it to 'ExampleSelector'. This is confusing because the file './components/terminal-grid-demo' exports 'TerminalGridDemo', not 'ExampleSelector'. The variable name should match the actual export.
packages/core/src/zig/utf8.zig:1 - The WrapBreak fields were changed from u16 to u32 to fix buffer overflow issues with text exceeding 64KB. While the test at line 975-996 validates this fix, the struct definition should include a comment explaining why u32 is required (e.g., '// u32 to support buffers > 64KB').
packages/core/src/zig/renderer.zig:1 - The code uses deprecated std.io.GenericWriter with a TODO comment acknowledging this. While the comment explains the situation, using deprecated APIs can lead to breakage in future Zig versions. Consider filing an issue to track this technical debt.
packages/core/src/zig/build.zig:1 - The SUPPORTED_ZIG_VERSIONS array now only contains 0.15.2, removing support for 0.14.x versions. This is a breaking change that should be clearly documented in release notes or migration guides, as users on 0.14.x will need to upgrade.
packages/core/src/zig/lib.zig:1 - The allocator was changed from page_allocator to GeneralPurposeAllocator. However, there's no cleanup code that calls gpa.deinit(). While this might be acceptable for a library that runs for the process lifetime, consider adding cleanup in a finalizer function or documenting why cleanup is not needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drag events should use 'M' (press) not 'm' (release) since the button is still held during drag operations.
Due to Bun stdin escape sequence handling issues on Windows (oven-sh/bun#22285), mouse drag events are not processed correctly, causing selection coordinates to be wrong. Skip these 2 tests on Windows until the Bun runtime issue is resolved.
- Skip viewport-aware selection test on Windows (same Bun stdin issue) - Increase timing tolerance for idle() tests on Windows (coarser timer resolution)
- mock-keys timing test: increase tolerance on Windows (coarser timer) - viewport scroll selection tests: skip on darwin too (timing flakiness) Windows issues caused by Bun stdin bug: oven-sh/bun#22285
macos-13 is deprecated (Oct 2025) with unreliable runner availability. No free x64 macOS runner is available anymore. darwin-arm64 provides sufficient macOS coverage.
CI environments have variable timing - darwin-arm64 also hit 71ms. Use 100ms for all platforms instead of platform-specific values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test failures fixed
/invalidpath succeeds (root user on musl, different path semantics on windows)