Skip to content

Master #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coriordan wants to merge 10 commits into
base: MOODLE_30_STABLE
Choose a base branch
from
Open

Master #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ab16f19
Removed unused More Meeting Detail link and broken Assign roles button
Jun 26, 2014
6ffe403
Merge branch 'MOODLE_30_STABLE' of github.com:remotelearner/moodle-mo…
coriordan May 11, 2017
efff0c4
identify returned recordings as icon=‘archive’
coriordan May 11, 2017
5da82b9
Merge branch 'feature/sco_duration_is_attribute' into develop
coriordan May 11, 2017
3f0f683
version 3.0.0.1
coriordan May 11, 2017
101a9ba
Merge branch 'release/3.0.0.1'
coriordan May 11, 2017
c7f7e7b
identify returned recordings as icon=‘archive’
coriordan May 11, 2017
7834d52
version 3.0.0.1
coriordan May 11, 2017
96effbd
Merge branch 'master' of github.com:wit-ctel/moodle-mod_adobeconnect
coriordan May 11, 2017
66733e4
Revert "Removed unused More Meeting Detail link and broken Assign rol…
coriordan May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions locallib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,8 +634,11 @@ function aconnect_get_recordings($aconnect, $folderscoid, $sourcescoid) {
if (!is_null($domnode)) {
$meetingdetail = $innernodelist->item($x);

// Check if the SCO item is a recording or uploaded document. We only want to display recordings
if (!is_null($meetingdetail->getElementsByTagName('duration')->item(0))) {
// Check if the SCO item is a recording or uploaded document. We only want to display recordings. Recordings are identified as an 'icon' attribute with a value of 'archive' in <sco> element, e.g. <sco icon='archive'>

$icontype = $meetingdetail->attributes->getNamedItem('icon');

if (!is_null($icontype) && $icontype->nodeValue === 'archive') {

$j = (int) $domnode->nodeValue;
$value = (!is_null($meetingdetail->getElementsByTagName('name'))) ?
Expand Down Expand Up @@ -668,8 +671,8 @@ function aconnect_get_recordings($aconnect, $folderscoid, $sourcescoid) {

$recordings[$j]->modified = (string) $value;

$value = (!is_null($meetingdetail->getElementsByTagName('duration'))) ?
$meetingdetail->getElementsByTagName('duration')->item(0)->nodeValue : '';
$value = (!is_null($meetingdetail->attributes->getNamedItem('duration'))) ?
$meetingdetail->attributes->getNamedItem('duration')->nodeValue : '';

$recordings[$j]->duration = (string) $value;

Expand Down
4 changes: 2 additions & 2 deletions version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
* @copyright (C) 2015 Remote Learner.net Inc http://www.remote-learner.net
*/

$plugin->version = 2015111000;
$plugin->version = 2017051100;
$plugin->requires = 2015101600;
$plugin->cron = 0;
$plugin->component = 'mod_adobeconnect';
$plugin->maturity = MATURITY_STABLE;
$plugin->release = '3.0.0.0';
$plugin->release = '3.0.0.1';