Support more audio formats in useWindowedAudioData
#5315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/windowed-audiodata-formats
…feature/windowed-audiodata-formats
…feature/windowed-audiodata-formats
…feature/windowed-audiodata-formats
…feature/windowed-audiodata-formats
…feature/windowed-audiodata-formats
…indow so we don’t miss samples that straddle window boundaries
…b1111 (Forbidden) is encountered as a sample rate
…feature/windowed-audiodata-formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5314
useWindowedAudioDatain music visualization templateAudioDecoderqueue will grow without any control and cause memory problems. Implement throttling for parsing as it's faster than decoding.getPartialAudioDataAPI to@remotion/webcodecs