[#768] msp430x: Fix immediate addressing #138
Open
+14
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes renode/renode#768
Description
The way MSP430X handles immediate values in the instruction is complicated because of the 20-bit extension.
The immediate addressing is represented in the instructions as
@PC+
. The current implementation is written along with@Rn+
. It is valid for 16-bit mode but not what is expected for 20-bit mode.The current implementation for
@PC+
here acts like:Expected behaviour
The address extension should be appended after fetching the immediate operand word.