Stashing(createPageRedirectAsyncData): Remove unused redirect from asyncData function#65
Draft
renoirb wants to merge 1 commit into
Draft
Stashing(createPageRedirectAsyncData): Remove unused redirect from asyncData function#65renoirb wants to merge 1 commit into
renoirb wants to merge 1 commit into
Conversation
33c314d to
5746f0d
Compare
5f0db3d to
b1e4276
Compare
5746f0d to
f911eea
Compare
c99b11f to
961bae4
Compare
961bae4 to
37dc1fb
Compare
renoirb
commented
Nov 3, 2024
renoirb
left a comment
Owner
Author
There was a problem hiding this comment.
Parts of this will be useful after all.
Owner
Author
There was a problem hiding this comment.
Let's not delete this aspect. It'll be useful after all in #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status Cannot merge as-is.
Because it seem to break due to the early use of Vue 3 API and those files seem to be involved in not breaking the build.
Instead of using Nuxt pages
asyncData, let's use the static site hosting redirects, and use insteadcreateVueMetaInfoFor example (taken from when it's been made):