Fix to Corrupt: TEXT value in notes.sfld.#62
Open
AldoMX wants to merge 2 commits intorepeat-space:masterfrom
Open
Fix to Corrupt: TEXT value in notes.sfld.#62AldoMX wants to merge 2 commits intorepeat-space:masterfrom
Corrupt: TEXT value in notes.sfld.#62AldoMX wants to merge 2 commits intorepeat-space:masterfrom
Conversation
AldoMX
commented
Dec 7, 2024
Comment on lines
+92
to
+97
| } else if (typeof sortField === 'string') { | ||
| const index = fields.indexOf(sortField); | ||
| if (index !== -1) { | ||
| intSortField = index; | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
The else if (typeof sortField === 'string') {} branch was added to preserve the behavior from #31, I can remove it if requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that a fix was proposed in #31, but the PR was breaking the API and the PR author never addressed the API breakage.
So this is a PR that builds on top of the proposed solution, without any API breakage.
This PR contains the following fixes:
ava&sqlite3createTemplate&exporter.addCard(feature proposed on Support more than two fields and custom sort field, get rid of extra object in save options merging #31)exporterto address theCorrupt: TEXT value in notes.sflderror, and update testsNOTE:
yarn.lockadds too much noise, the PR is actually smaller.