Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don’t do unnecessary “home – go to z probe distance – home” movements before auto-leveling #774

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

gkaindl
Copy link

@gkaindl gkaindl commented Apr 9, 2018

for delta printers when doing G32 auto-levelling, it'll first run Printer::prepareForProbing(), which homes all axes and then goes down to the z-probe bed distance. however, it'll then home again due to unconditional homing in line 329, which repeats those motions unnecessarily.

as a fix, I'd suggest removing the call to Printer::prepareForProbing() for delta printers, since it doesn't do anything besides those movements. alternatively, either instance of the homing/go-to-z-probe-distance movements can be removed from either prepareForProbing() or runBedLevelling() – I'm not sure which is the ideal solution.

@gkaindl gkaindl changed the base branch from master to development April 9, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant