fix(build): make buildtools update go dependency#3782
Merged
Conversation
buildtools should modify the dependent k0s go dependency to match the version of k0s being targetted Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Signed-off-by: Evans Mungai <evans@replicated.com>
version_suffix already includes a leading dash, so the copy target
embedded-cluster-${version_suffix} produced a double-dash filename that
the upload step never matched (silently uploaded nothing under
if-no-files-found: warn). The new per-minor check-images matrix is the
first consumer of previous-k0s-N-release, exposing the mismatch. Drop
the extra dash so the binary, upload path, and check-images download
agree.
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
sgalsaleh
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
buildtoolsmake target should modify the dependent k0s go dependency to match the version of k0s being targeted. Update CI workflow to ensure builds succeed for each minorWhich issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?