Skip to content

Conversation

@NoaheCampbell
Copy link
Contributor

Description, Motivation and Context

Instead of running every test for all changes, this aims to run only tests that are relevant to the changes made in a pull request. For example if a PR introduces changes to collectors, it would run preflight and support bundle tests since both are affected, however if a change is only made to preflight, only preflight tests would be run.

The reason behind this is to reduce time spent on waiting for tests to run and pass or fail as there are many situations where not every single test needs to be run

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

This was turning into something worthy of its own PR so I put it back to how it was before to work on next/separately
# this job will validate that the validation did not fail and that all pr-tests succeed
# it is used for the github branch protection rule
validate-success:
if: ${{ always() && github.event_name == 'push' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Branch Protection Bypassed by Job Event Change

The validate-success job, intended for GitHub branch protection, now only runs on push events. This prevents the required status check from being available for pull requests, breaking branch protection.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant