Fix PlatformException(Bad Arguments, Could not set client, view ID is null., null, null)#88
Conversation
… null., null, null)
ghost
mentioned this pull request
mast3rmindx
referenced
this pull request
in mast3rmindx/re-editor
Jun 9, 2025
This commit applies a fix from upstream commit d448e01d8ff25081209d1ac7d1058503251670f6 (from reqable/re-editor PR #88). The main change is to provide a valid `viewId` when establishing the TextInputConnection in `_CodeInputController._openInputConnection()`. This is done by retrieving the `viewId` using `ui.PlatformDispatcher.instance.implicitView?.viewId ?? View.maybeOf(_editorKey!.currentContext!)?.viewId;` and passing it to the `TextInputConfiguration`. This change is intended to resolve a `PlatformException(Bad Arguments, Could not set client, view ID is null., null, null)` that could occur when the text input system was initialized without a viewId.
|
This fixes windows, thanks! Can we have this reviewed and merged please? |
Member
|
Thanks for this PR. There was a break change in TextInputConfiguration, see flutter/flutter@42988d1. Merging this PR requires raising the minimum Flutter version. |
Member
|
I have committed a commit to fix this issue, please see a312927. Theoretically, there will be no breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformException error on flutter version 3.32.0
#83