Skip to content

Comments

Another incremental python typing step#12497

Draft
ntjohnson1 wants to merge 4 commits intomainfrom
nick/more_ty
Draft

Another incremental python typing step#12497
ntjohnson1 wants to merge 4 commits intomainfrom
nick/more_ty

Conversation

@ntjohnson1
Copy link
Member

@ntjohnson1 ntjohnson1 commented Jan 16, 2026

Related

Turn on more TY rules. Upgrade mypy for consistency with newer TY.
Start filing/finding issues for the small edge cases TY doesn't support for us.

What

Follow on note. What is visible? We don't seem to use it anywhere so might be a code gen artifact. For now I left the runtime test but ignore the typing error.

@ntjohnson1 ntjohnson1 added exclude from changelog PRs with this won't show up in CHANGELOG.md 🧑‍💻 dev experience developer experience (excluding CI) labels Jan 16, 2026
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Web viewer built successfully.

Result Commit Link Manifest
17def19 https://rerun.io/viewer/pr/12497 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Latest documentation preview deployed successfully.

Result Commit Link
17def19 https://landing-9pb9uunnz-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@ntjohnson1
Copy link
Member Author

@rerun-bot sync

@ntjohnson1
Copy link
Member Author

@rerun-bot reality-sync

@rerun-sync
Copy link
Contributor

rerun-sync bot commented Jan 30, 2026

Sync complete. Mirror PR in reality: https://github.com/rerun-io/reality/pull/374

Triggered by @ntjohnson1

@rerun-sync
Copy link
Contributor

rerun-sync bot commented Jan 30, 2026

⚠️ This PR was not auto-merged

The corresponding reality PR was merged: https://github.com/rerun-io/reality/pull/374

However, this PR could not be automatically merged because: verification error: gh command failed: gh pr merge 12497 --repo rerun-io/rerun --squash --admin --match-head-commit 17def19 --subject Another incremental python typing step (#12497) --body ### Related
Turn on more TY rules. Upgrade mypy for consistency with newer TY.
Start filing/finding issues for the small edge cases TY doesn't support for us.

What

Follow on note. What is visible? We don't seem to use it anywhere so might be a code gen artifact. For now I left the runtime test but ignore the typing error.

Source-Ref: 81b475756dabc3aaeaceecc089166a4b0e1dc794 --delete-branch
GraphQL: Pull Request is still a draft (mergePullRequest)

The changes have been synced via a direct commit instead: 80aac8a

This PR can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant