Be more aware of the workspace during clean

[nojaf]

This is an attempt to drive the conversation at #7707

In case of clean, we already do an upward traversal to find a root rescript json.
I'm adding some logic to check if the parent rescript json contains the current rescript json in "dependencies" (or "dev-dependencies").

If we did find a link, we would only remove the files from the current project and not everything.

Consider https://github.com/nojaf/rescript-kaplay/blob/main/packages/rescript-kaplay/rescript.json

We already find https://github.com/nojaf/rescript-kaplay/blob/d38649fcd409c174c39b31488f790e036f3b0a20/rescript.json#L8

If that name matches root_package (in the code, a bit confusing name) is "@nojaf/rescript-kaplay", so we only need to remove those files.

Files from https://github.com/nojaf/rescript-kaplay/blob/main/packages/samples/rescript.json are unaffected.

If we were to clean from the repo root, root_config would be the well the root package and everything gets cleaned.

[nojaf]

Let me know if something doesn't make any sense.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7752

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7752

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7752

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7752

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7752

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7752

commit: f76b55b

[nojaf]

I think it might make sense to rethink the format command as well.

Would it not be more consistent if we format either:

• a specific file argument like format Foo.res
• Format all projects in case of a monorepo when invoked at the root.
• Format a specific project only when it is part of a workspace, but invoked at the project level and not the root.

The --all flag seems a bit off compared to clean.

[cknitt]

Agreed, defaulting to all / keeping args similar to build/clean definitely makes sense!

[nojaf]

There still is more work to do here.
In general the concept of current_package and workspace_package and their relation should be cemented more in all code paths.

my-monorepo/
  packages/
    a/
      rescript.json
    b/
      rescript.json
rescript.json

Running clean, build, format and compiler-args inside a or my-monorepo need to clearly defined.

	repository (my-monorepo)	package (a)	expectation repository	expectation project
compiler-args	packages/a/src/File.res	src/Files.res	Get compiler args. Extension from repo is used	Exact same result, extension from repo is used
format			All files of all packages are formatted	Files of current package are formatted
build			All packages are built	Only this package is built
clean			All packages are cleaned	Only this packaged is cleaned

I also think that if there is no link with package and repository rescript, workspace_path should be None.

For the time being if there is a workspace rescript.json, that "suffix" is primary.
Nested rescript.json files cannot define it again. Maybe we add a warning for that.

Post v12 we can explore the option to override suffix in child packages, but it is my understanding that it doesn't work that way today.

_{I'm also in favour of renaming root_package of current_package in code.}

[Copilot]

Pull Request Overview

This PR enhances workspace awareness during the clean command by introducing a ProjectContext enum that better categorizes project structures (single project, monorepo root, or monorepo package). The key improvement is that when cleaning from within a monorepo package, only files belonging to that specific package are removed rather than cleaning the entire workspace.

• Introduces a new ProjectContext enum to categorize project relationships and scope operations accordingly
• Refactors the clean command to respect workspace boundaries and only clean relevant packages
• Removes the --all flag from the format command, making it the default behavior when no files are specified

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
rewatch/src/project_context.rs	Adds new ProjectContext enum and logic to determine workspace relationships
rewatch/src/build/clean.rs	Updates clean operations to use ProjectContext for scoped cleaning
rewatch/src/format.rs	Removes --all flag and uses ProjectContext for scoped formatting
rewatch/src/cli.rs	Removes --all flag from format command CLI definition
rewatch/src/build/packages.rs	Refactors dependency reading to use ProjectContext instead of workspace_root
rewatch/src/build/build_types.rs	Updates BuildState to use ProjectContext and adds get_root_package method
rewatch/src/helpers.rs	Adds is_local_package helper and updates get_rescript_legacy function
rewatch/src/main.rs	Updates format command call to remove all parameter
rewatch/src/lib.rs	Adds project_context module
Multiple build files	Updates function signatures to use ProjectContext instead of separate workspace parameters