Bump schemars dependency to 1.2 #4126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
bump-schemars
branch
3 times, most recently
from
2e8ee1d to
3b7a754
Compare
tillrohrmann
force-pushed
the
bump-schemars
branch
2 times, most recently
from
623ee11 to
593ed26
Compare
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Small comment, and then LGTM
crates/types/src/net/address.rs
Outdated
| fn json_schema(_generator: &mut schemars::SchemaGenerator) -> schemars::Schema { | ||
| schemars::json_schema!({ | ||
| "type": "string", | ||
| "format": "ip:port", |
Contributor
There was a problem hiding this comment.
A note about formats (here and in other places).
format is a json schema keyword which accepts either "well defined formats" or "custom formats". Problem is, some codegens won't like custom formats, and might behave erratically with those.
So please remove all the usages of "custom formats", and just keep the "formats" when they're part of this well-defined list: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#rfc.section.7.3
Contributor
Author
There was a problem hiding this comment.
Thanks for the pointer. Ok, then I'll remove the custom formats.
This fixes restatedev#3766.
While custom formats are supported by JSON schema, it makes some code generator tools to trip over them. Hence, we are removing custom formats from the code base.
tillrohrmann
force-pushed
the
bump-schemars
branch
from
2b1ca74 to
7a95273
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #4125.
This fixes #3766.