[Bifrost] Improve error reporting on append failures #4134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jan 5, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Really nice improvements @AhmedSoliman! LGTM :-) +1 for merging.
When an append wave fails, we'll now report the last error message from each node that failed. Additionally, when a connection is lost due to receive error (e.g. decoding error), we'll report a warning message with the status code returned from tonic. Closes #4131. Bonus: the append wave failure includes the estimated number of bytes in the payload. Example messages from log: ``` 2026-01-05T14:43:21.134839Z WARN restate_bifrost::providers::replicated_loglet::sequencer::appender Append wave failed, retrying with a new wave after 5.394872401s. Status is [N1(ERROR(attempts=63, last_err='connection closed')), N2(ERROR(attempts=63, last_err='connection closed')), N4(ERROR(attempts=63, last_err='connection closed'))] wave: 63 loglet_id: 14_5 first_offset: 2 to_offset: 5 length: 4 estimated_bytes: 40002500 otel.name: "replicated_loglet::sequencer::appender: run" on rs:worker-8 2026-01-05T14:44:07.852911Z WARN restate_core::network::grpc::svc_handler Error while receiving network message from peer, connection will be dropped err: status: 'Internal error', self: "h2 protocol error: error reading a body from connection" on rs:worker-3 in restate_core::network::io::reactor::network-reactor peer: N1:3 task_id: 4076 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an append wave fails, we'll now report the last error message from each node that failed. Additionally, when a connection is lost due to receive error
(e.g. decoding error), we'll report a warning message with the status code returned from tonic. Closes #4131.
Bonus: the append wave failure includes the estimated number of bytes in the payload.
Example messages from log:
Stack created with Sapling. Best reviewed with ReviewStack.