Skip to content

Removes max_encoding_message_size from all grpc servers and clients #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmedSoliman merged 1 commit into from
Jan 7, 2026
Merged

Removes max_encoding_message_size from all grpc servers and clients #4135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/admin/src/cluster_controller/grpc_svc_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ impl ClusterCtrlSvcHandler {
pub fn into_server(self, config: &NetworkingOptions) -> ClusterCtrlSvcServer<Self> {
let server = ClusterCtrlSvcServer::new(self)
.max_decoding_message_size(config.max_message_size.as_usize())
.max_encoding_message_size(config.max_message_size.as_usize())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down
1 change: 0 additions & 1 deletion crates/core/src/network/grpc/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ impl TransportConnect for GrpcConnector {

// Establish the connection
let client = CoreNodeSvcClient::new(channel)
.max_encoding_message_size(MAX_MESSAGE_SIZE)
.max_decoding_message_size(MAX_MESSAGE_SIZE)
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
Expand Down
1 change: 0 additions & 1 deletion crates/core/src/network/grpc/svc_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ impl CoreNodeSvcHandler {
pub fn into_server(self, config: &NetworkingOptions) -> CoreNodeSvcServer<Self> {
let server = CoreNodeSvcServer::new(self)
.max_decoding_message_size(MAX_MESSAGE_SIZE)
.max_encoding_message_size(MAX_MESSAGE_SIZE)
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down
2 changes: 0 additions & 2 deletions crates/core/src/protobuf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ pub mod cluster_ctrl_svc {
connection_options: &O,
) -> cluster_ctrl_svc_client::ClusterCtrlSvcClient<tonic::transport::Channel> {
cluster_ctrl_svc_client::ClusterCtrlSvcClient::new(channel)
.max_encoding_message_size(connection_options.max_message_size())
.max_decoding_message_size(connection_options.max_message_size())
// note: the order of those calls defines the priority
.accept_compressed(tonic::codec::CompressionEncoding::Zstd)
Expand Down Expand Up @@ -69,7 +68,6 @@ pub mod node_ctl_svc {
connection_options: &O,
) -> NodeCtlSvcClient<Channel> {
node_ctl_svc_client::NodeCtlSvcClient::new(channel)
.max_encoding_message_size(connection_options.max_message_size())
.max_decoding_message_size(connection_options.max_message_size())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
Expand Down
1 change: 0 additions & 1 deletion crates/log-server-grpc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ pub fn new_log_server_client(

log_server_svc_client::LogServerSvcClient::new(channel)
.max_decoding_message_size(MAX_MESSAGE_SIZE)
.max_encoding_message_size(MAX_MESSAGE_SIZE)
// note: the order of those calls defines the priority
.accept_compressed(tonic::codec::CompressionEncoding::Zstd)
.accept_compressed(tonic::codec::CompressionEncoding::Gzip)
Expand Down
1 change: 0 additions & 1 deletion crates/log-server/src/grpc_svc_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ where
pub fn into_server(self, config: &NetworkingOptions) -> LogServerSvcServer<Self> {
let server = LogServerSvcServer::new(self)
.max_decoding_message_size(MAX_MESSAGE_SIZE)
.max_encoding_message_size(MAX_MESSAGE_SIZE)
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down
1 change: 0 additions & 1 deletion crates/log-server/src/protobuf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ pub fn new_log_server_client(
use restate_core::network::grpc::{DEFAULT_GRPC_COMPRESSION, MAX_MESSAGE_SIZE};
log_server_svc_client::LogServerSvcClient::new(channel)
.max_decoding_message_size(MAX_MESSAGE_SIZE)
.max_encoding_message_size(MAX_MESSAGE_SIZE)
// note: the order of those calls defines the priority
.accept_compressed(tonic::codec::CompressionEncoding::Zstd)
.accept_compressed(tonic::codec::CompressionEncoding::Gzip)
Expand Down
1 change: 0 additions & 1 deletion crates/metadata-server-grpc/src/grpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ where

metadata_server_svc_client::MetadataServerSvcClient::new(channel)
.max_decoding_message_size(connection_options.max_message_size())
.max_encoding_message_size(connection_options.max_message_size())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip)
Expand Down
1 change: 0 additions & 1 deletion crates/metadata-server/src/grpc/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ impl MetadataServerHandler {
pub fn into_server(self, config: &NetworkingOptions) -> MetadataServerSvcServer<Self> {
let server = MetadataServerSvcServer::new(self)
.max_decoding_message_size(config.max_message_size.as_usize())
.max_encoding_message_size(config.max_message_size.as_usize())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down
1 change: 0 additions & 1 deletion crates/metadata-server/src/raft/network/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ impl<M> MetadataServerNetworkHandler<M> {
pub fn into_server(self, config: &NetworkingOptions) -> MetadataServerNetworkSvcServer<Self> {
let server = MetadataServerNetworkSvcServer::new(self)
.max_decoding_message_size(config.max_message_size.as_usize())
.max_encoding_message_size(config.max_message_size.as_usize())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down
1 change: 0 additions & 1 deletion crates/metadata-store/src/protobuf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ pub mod metadata_proxy_svc {
options: &O,
) -> MetadataProxySvcClient<Channel> {
MetadataProxySvcClient::new(connection_options)
.max_encoding_message_size(options.max_message_size())
.max_decoding_message_size(options.max_message_size())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
Expand Down
2 changes: 0 additions & 2 deletions crates/node/src/network_server/grpc_svc_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ impl NodeCtlSvcHandler {
pub fn into_server(self, config: &NetworkingOptions) -> NodeCtlSvcServer<Self> {
let server = NodeCtlSvcServer::new(self)
.max_decoding_message_size(config.max_message_size.as_usize())
.max_encoding_message_size(config.max_message_size.as_usize())
// note: the order of those calls defines the priority
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
Expand Down Expand Up @@ -276,7 +275,6 @@ impl MetadataProxySvcHandler {
let server = MetadataProxySvcServer::new(self)
// note: the order of those calls defines the priority
.max_decoding_message_size(config.max_message_size.as_usize())
.max_encoding_message_size(config.max_message_size.as_usize())
.accept_compressed(CompressionEncoding::Zstd)
.accept_compressed(CompressionEncoding::Gzip);
if config.disable_compression {
Expand Down
Loading