[Bifrost] BackgroundAppender respects record-size-limit when cutting batches #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2026
Test Results 5 files - 2 5 suites - 2 1m 14s ⏱️ - 2m 7s Results for commit d4a4d9c. ± Comparison against base commit 81a5288. This pull request removes 47 and adds 34 tests. Note that renamed tests count towards both. |
tillrohrmann
approved these changes
Jan 8, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Great work @AhmedSoliman. Thanks a lot for making our batching logic aware of byte limits so that we don't generate too large batches! LGTM. +1 for merging :-)
| let token = sender.notify_committed().await?; | ||
| token.await?; | ||
|
|
||
| handle.drain().await?; |
Contributor
There was a problem hiding this comment.
Is this important for the below assertion to succeed? Or would it be enought to await the token and then to the find_tail operation?
Contributor
Author
There was a problem hiding this comment.
it's superfluous.
AhmedSoliman
force-pushed
the
pr4144
branch
2 times, most recently
from
e3c3aca to
efa7924
Compare
Add a record size limit check at append time in Bifrost to validate that individual records do not exceed a configured maximum size. Important note: This configuration option is not going to be effective without implementing size estimation of records. At the moment, all typed records are assumed to be 2048 bytes in size which makes this check useless. Nevertheless, This check is useful for the future when we implement size estimation of records. Changes: - Add `bifrost.record-size-limit` configuration option that defaults to `networking.message-size-limit` (32 MiB) and is clamped to that value - Add `BatchTooLarge/RecordTooLarge` error variants to get notified when a record too large or when a batch is too large depending on whether you're using Appender or BackgroundAppender. - Add record size validation to all `LogSender` enqueue methods in `BackgroundAppender` to fail fast at enqueue time This prevents oversized records from being written to the log, which could cause issues during replication and network transmission. Part of #4130, #4132
The goal is to make sure that the user can still set the VO state to a value within the message size limit without failing. For instance, using the large-state-service, with this change, we can do: ``` curl http://localhost:8080/LargeState/224/state --silent --json '50000000' "State set"% ``` While running the server with ```RESTATE_NETWORKING__MESSAGE_SIZE_LIMIT=50000000``` Related to #4130
…batches Previously, BackgroundAppender used recv_many() to batch records by count only (max_batch_size). This change adds byte-size awareness to batch cutting, ensuring batches do not exceed the configured record_size_limit. Closes #4132 Changes: - Introduce Batch struct to track accumulated bytes alongside operations - Add AppendOperation::cost_in_bytes() to calculate record sizes - Replace recv_many() with recv()/try_recv() loop that checks both byte and count limits before adding to batch - Flush batch when adding a new operation would exceed limits - Use cancellation_token() instead of cancellation_watcher() for drain The batch is cut when either: - Adding the next record would exceed batch_limit_bytes - The batch reaches max_batch_size count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, BackgroundAppender used recv_many() to batch records by count
only (max_batch_size). This change adds byte-size awareness to batch cutting,
ensuring batches do not exceed the configured record_size_limit.
Closes #4132
Changes:
and count limits before adding to batch
The batch is cut when either:
Stack created with Sapling. Best reviewed with ReviewStack.