Skip to content

feat: metadata in packet wrapper system #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

feat: metadata in packet wrapper system #1195

wants to merge 6 commits into from

Conversation

@felipepasc
Copy link

@felipepasc felipepasc commented Apr 9, 2025 •
edited
Loading

.

@felipepasc
feat: metadata in packet wrapper system
70ef892
@felipepasc
fix(meta): adjust timestamp calculation in PacketWrapperMeta
aa3bf5c
@felipepasc
fix: remove WrappedIdentifyByteBuf
41f3214
@felipepasc
refactor(wrapper): improve code readability
52b6edf
@felipepasc
feat(meta): refactor metadata handling in PacketWrapper
60ffe22 
```
- Made metadata nullable and initialize it only when needed.
- Updated setMeta to instantiate metadata if null.
- Changed getMeta and hasMeta to utilize PacketWrapperMetaCache.
- Removed unused methods and improved method signatures for clarity.
```
@felipepasc
Merge branch 'retrooper:2.0' into 2.0
7d09e88
@NoJokeFNA
Copy link
Contributor

NoJokeFNA commented Oct 27, 2025 •
edited
Loading

What is your usecase?
Also, please don't change any code style relating stuff (like empty lines) in classes you don't even touch.
If you want to fix formatting, or anything like this, please create a separate PR.

@retrooper
Copy link
Owner

retrooper commented Nov 5, 2025

Your PR has been assessed. If there are any reviewer comments on your PR, you can locate them near the end of this message.
Regrettably, your PR has been rejected for inclusion in PacketEvents.

Unfortunately, I fail to see how these changes are novel and well thought out.
Moreover, you seem to change the formatting in classes without making any
significant changes to behavior. If you want to propose a feature to be added
to the API, please do so through the GitHub Issues section. That way, we can advise
you on whether it is something we will accept, and we can advise you on
how to implement the change.

Thank you for the opportunity to review your PR. I'm sorry that we cannot be more positive on this occasion and hope you will not be deterred from submitting future work to PacketEvents.

@retrooper retrooper closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felipepasc @NoJokeFNA @retrooper