Finish exceptionCaught in velocity's PacketEventsEncoder - #1536
Open
ShadowOfHeaven-Me wants to merge 8 commits into
Open
Finish exceptionCaught in velocity's PacketEventsEncoder#1536ShadowOfHeaven-Me wants to merge 8 commits into
ShadowOfHeaven-Me wants to merge 8 commits into
Conversation
booky10
requested changes
Jun 22, 2026
booky10
left a comment
booky10
left a comment
Collaborator
There was a problem hiding this comment.
Also missing in PacketEventsDecoder (and argueably more important there)
| if (didWeCauseThis | ||
| && (user == null || user.getEncoderState() != ConnectionState.HANDSHAKING)) { | ||
| if (PacketEvents.getAPI().getSettings().isFullStackTraceEnabled()) { | ||
| cause.printStackTrace(); |
Collaborator
There was a problem hiding this comment.
Should be logged using the LogManager
| if (PacketEvents.getAPI().getSettings().isFullStackTraceEnabled()) { | ||
| cause.printStackTrace(); | ||
| } else { | ||
| PacketEvents.getAPI().getLogManager().warn(cause.getMessage()); |
Collaborator
There was a problem hiding this comment.
Make sure to include some info about the user which caused this here (also applies to above)
| throw new AssertionError(); | ||
| } | ||
| } | ||
| } No newline at end of file |
…pl/netty/util/WrapperUtil.java Co-authored-by: booky <booky@booky.dev>
…pl/netty/util/WrapperUtil.java Co-authored-by: booky <booky@booky.dev>
…rs/PacketEventsEncoder.java Co-authored-by: booky <booky@booky.dev>
…rs/PacketEventsEncoder.java Co-authored-by: booky <booky@booky.dev>
…rs/PacketEventsEncoder.java Co-authored-by: booky <booky@booky.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not account for PacketEvents.getAPI().getSettings()