localnode access service #646
Open
+1,000
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| on<direct_access::write_data>("write_data", std::bind(&direct_access_t::write_data, this, _1, _2, _3)); | ||
|
|
||
| // find all groups that resides on our node, and set them as session default | ||
| m_session_proto.set_groups(find_local_groups(m_session_proto)); |
There was a problem hiding this comment.
This will force m_session_proto to perform action on every single group which is present in current server's config.
It is probably not intended behaviour
There was a problem hiding this comment.
Group list in session_proto work only as default, it gets corrected on every operation.
ijon
force-pushed
the
feature-local-node-access-service
branch
2 times, most recently
from
43a1c92
to
6692cfd
Compare
ijon
force-pushed
the
feature-local-node-access-service
branch
from
6692cfd
to
ef85113
Compare
ijon
force-pushed
the
feature-local-node-access-service
branch
from
ef85113
to
52ef39f
Compare
Localnode is a cocaine service built in srw. Internally it directly uses server's node and (through a very simplified interface) gives access to basic data operations without the need to use and configure the actual elliptics client. In essence, localnode service is an another entry point for clients that use cocaine channel and protocol.
Also logging cleanup
ijon
force-pushed
the
feature-local-node-access-service
branch
from
52ef39f
to
298c734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR contains work on
localnodeservice.localnodeservice is a cocaine service spinned off by the srw and its purpose is to give srw workers and other local (also remote) users easy access to the facilities of the local elliptics node.localnodeclosely resembles existingellipticsservice, but unlike itlocalnodedirectly communicates with server node, so there is no middle layers, no additional costs and no configuration.That is the main reason behind
localnode.This code is actually a revival of someone's previous effort, dusted off and cleaned up a bit.
As it is,
localnodeservice is in working condition and is tested, but it's not ready for inclusion into a mainline yet.Future direction:
ellipticsservice, they are supposedly too similar to have them both; it could be one implementation (interface layer and all) with initialization which takes either client elliptics node (ellipticsservice in a pure cocaine cloud) or server elliptics node (localnoderunning inside srw)Ugliness
cocaine/include/cocaine/actor.hppis a pristine copy of actor.hpp from cocaine-core sources. There is no other way, unfortunately: srw require actor_t defined in actor.hpp to be able to register localnode without requiring external config, but, by whatever reason, actor.hpp doesn't considered a part of public interface in cocaine v0.11 (in cocaine v0.12 it does).This change is