Core: bypass write to pipe for local transactions #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked dnet_io_req_queue function to pass io_req struct directly to the proper IO pool, eliminating write/read through pipe in net pool.
| @@ -192,7 +206,10 @@ static struct dnet_io_req *dnet_io_req_copy(struct dnet_net_state *st, struct dn | |||
|
|
|||
| offset = r->hsize; | |||
| memcpy(r->header, orig->header, r->hsize); | |||
| } | |||
| } else if (read_data) { | |||
| r->header = buf + sizeof(struct dnet_io_req); | |||
There was a problem hiding this comment.
If orig doesn't have header, why does it set r->header here?
|
Why is this needed? Do you have so many local requests which come from one queue to another? |
|
We want to run traffic-intensive wokers with SRW, and use Cocaine localnode service (it will be in separate PR later) to access data. We do not want to start elliptics client in each worker because our cluster is pretty large, and we can't update it (elliptics client inside worker's code) in case of Elliptics cluster major version upgrade. |
To isolate work with dnet_io_req data pointers request fixup was moved to dnet_io_req_copy function from dnet_io_req_queue.
|
@toshic It is ready to be merged, isn't it? |
|
I shink so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked dnet_io_req_queue function to pass io_req struct directly
to the proper IO pool, eliminating write/read through pipe in net pool.