-
Notifications
You must be signed in to change notification settings - Fork 174
Add overview stats in trial stats #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
A preview of 0f72ad2 is uploaded and can be seen here: ✨ https://revisit.dev/study/PR939 ✨ Changes may take a few minutes to propagate. |
| function getNextComponent(participant: ParticipantData): string | undefined { | ||
| const flatSequence = getSequenceFlatMap(participant.sequence); | ||
| return flatSequence.find((comp) => { | ||
| const compAnswer = Object.values(participant.answers).find((a) => a.componentName === comp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work for duplicated components? Perhaps we should be using trial order instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check throughout this file
Does this PR close any open issues?
Closes #852
Give a longer description of what this PR addresses and why it's needed
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: