Skip to content

Conversation

@yeonkim1213
Copy link
Contributor

@yeonkim1213 yeonkim1213 commented Oct 29, 2025

Does this PR close any open issues?

Closes #852

Give a longer description of what this PR addresses and why it's needed

  • Add overview stats to trial stats
  • Debug overview stats (in-progress participants were not counted correctly in trial stats)
  • Fix issues with average time and average clean time (If time navigated away is larger than duration, it gave negative values)

Provide pictures/videos of the behavior before and after these changes (optional)

image

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Update documentation screenshots
  • Add comments to utils.tsx
  • Remove overview stats if the component is not selected
  • add date back

@yeonkim1213 yeonkim1213 added this to the v2.4 milestone Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

A preview of 0f72ad2 is uploaded and can be seen here:

https://revisit.dev/study/PR939

Changes may take a few minutes to propagate.

@yeonkim1213 yeonkim1213 changed the base branch from main to dev October 29, 2025 19:46
@yeonkim1213 yeonkim1213 marked this pull request as ready for review October 29, 2025 21:20
function getNextComponent(participant: ParticipantData): string | undefined {
const flatSequence = getSequenceFlatMap(participant.sequence);
return flatSequence.find((comp) => {
const compAnswer = Object.values(participant.answers).find((a) => a.componentName === comp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for duplicated components? Perhaps we should be using trial order instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check throughout this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a header to trial stats

3 participants