Refactor and fix replay #971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
x
Give a longer description of what this PR addresses and why it's needed
Instead of passing time related props and handling time separately on each component, this PR introduces a hook to let components subscribe to replay events (play, pause, timeupdate).
The hook handles media elements (video and audio) and provenance timeline.
If media elements aren't present, the hook uses starts its own timer.
The timeupdate event gives the current time of the timeline. The timing information is prioritized as: video > audio > provenance timeline, meaning that video's time is prioritized over others if available.
This PR also fixes the issue when seeking is done while media is playing.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
x