Network Optimization (BoundQueue Refactor) #133
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 25, 2025
Learn more in the Cursor dashboard.
| } | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
Bug: Function Uses Incorrect Variable for Validation
The IsValidGMASOperation function incorrectly uses the member variable OperationData for its validation checks (e.g., IsValid() and GetPtr<>()) instead of the Data parameter. This leads to improper validation of input operations.
| // Show client-side data | ||
| if (AbilityComponent) | ||
| { | ||
| if (DataPack.NBActiveEffectData != AbilityComponent->ActiveEffectIDs.Num()) |
There was a problem hiding this comment.
Bug: Incorrect Cached Operations Incoherency Check
The Gameplay Debugger's "Cached Operations" display incorrectly checks for data incoherency. It compares DataPack.NBActiveEffectData with AbilityComponent->ActiveEffectIDs.Num() instead of DataPack.NBCachedOperationPayloads with AbilityComponent->BoundQueueV2.OperationPayloads.Num(). This leads to inaccurate incoherency detection for cached operations.
| UE_LOG(LogGMCAbilitySystem, Error, TEXT("No Abilities Granted for InputTag: %s"), *InputTag.ToString()); | ||
| return false; | ||
| } | ||
| bool bFirstAbilityActivatesDuringMovementTick = GrantedAbilities[0]->GetDefaultObject<UGMCAbility>()->bActivateOnMovementTick; |
There was a problem hiding this comment.
Bug: Null Pointer in Ability Activation
Null pointer dereference in UGMC_AbilitySystemComponent::TryActivateAbilitiesByInputTag. The code accesses GrantedAbilities[0] and calls GetDefaultObject() without validating that GrantedAbilities[0] is a valid class pointer. Although the array's size is checked, individual elements are not, which can lead to a crash if GetGrantedAbilitiesByTag returns null class pointers.
| { | ||
| return QueuedAbilityOperations.NumMatching(AbilityTag, EGMASBoundQueueOperationType::Activate); | ||
| return 0; | ||
| // return QueuedAbilityOperations.NumMatching(AbilityTag, EGMASBoundQueueOperationType::Activate); |
There was a problem hiding this comment.
Bug: Queued Abilities Count Always Zero
The GetQueuedAbilityCount function was stubbed out to always return 0, preventing accurate retrieval of the number of queued abilities and breaking any dependent ability activation or queueing logic.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
| else | ||
| { | ||
| BoundQueueV2.QueueServerOperation(OperationID); |
There was a problem hiding this comment.
Bug: bPreventConcurrentActivation parameter is completely ignored
The QueueAbility function accepts a bPreventConcurrentActivation parameter but never uses it. The old implementation had logic to prevent concurrent activation of abilities, but this was removed during the refactor without being reimplemented, allowing duplicate ability activations that were previously blocked.
Note
Refactors networking to new BoundQueueV2 with cached client/server operations and acks, switches effect replication to IDs, updates debugger, and enables Niagara.
GMASBoundQueuewith newFGMASBoundQueueV2pipeline bound via GMC (OperationData, caching, client/server queues, grace-period force, acks).GMASBoundQueueV2_Operations(ability activation, acknowledge, apply/remove effect, add impulse, set actor location, custom event).ProcessOperation,ServerProcessOperation,ServerProcessAcknowledgedOperation, payload caching/expiration, and ancillary/prediction integration.ActiveEffectsDatatoActiveEffectIDswithOnRep_ActiveEffectIDs; update cleanup and ID reservation/validation.TryActivateAbilitiesByInputTagnow returnsbooland supportsbForce;QueueAbilityqueuesFGMASBoundQueueV2AbilityActivationOperation.ActiveEffectIDsand show cached operation payload count.RPCOnServerOperationAdded; handlerOnServerOperationForced.Niagaraplugin in.uplugin.GMASBoundQueuefiles/usages.Written by Cursor Bugbot for commit 58e9d6b. This will update automatically on new commits. Configure here.