Fix AR type cast to mirror quoting

[nikolai-b]

It seems wrong that

SpatialModel.where("ST_DWITHIN(latlon_geo, ?, 500)", geographic_factory.point(-72.099, 42.099)).to_sql

uses the EWKB format but when the query is actually executed it uses to_s which uses the WKT without passing any SRID. This was causing me issues for me with preprepared statements but I couldn't create a simple text. I do think this gem should pass the SRID of bindings though.

I'm not very happy with the test I've written here. I looked .values_for_queries or looking at the arel but the binds haven't been type_cast at this point so I've used explain.

[keithdoggett]

@nikolai-b thanks for the PR! I think this looks good. Was this only effecting prepared geometries? I thought there was some work done recently that added the SRID to the generated string in the rgeo-activerecord gem.

[inkstak]

I suggested a similar PR #430 before finding yours.
Yours seems more complete since you handled bounding boxes.

[todtb]

@keithdoggett

I thought there was some work done recently that added the SRID to the generated string in the rgeo-activerecord gem.

As of rgeo (3.0.1) and rgeo-activerecord (8.0.0) it does not look to be adding SRID. Rather, to_s returns non-extended WKT.

Re test assertions: From the testing I've done, the proposed changes look good and address the issue by using EWKB. (In my case, this was ultimately used with ST_Intersects) Upon inspection, the type_casted_binds in the adapter look good and I think the EXPLAIN approach is sufficient.

[nikolai-b]

@inkstak thanks, I copied the logic from

activerecord-postgis-adapter/lib/active_record/connection_adapters/postgis_adapter.rb

Lines 122 to 130 in 5d380da

	def quote(value)
	if RGeo::Feature::Geometry.check_type(value)
	"'#{RGeo::WKRep::WKBGenerator.new(hex_format: true, type_format: :ewkb, emit_ewkb_srid: true).generate(value)}'"
	elsif value.is_a?(RGeo::Cartesian::BoundingBox)
	"'#{value.min_x},#{value.min_y},#{value.max_x},#{value.max_y}'::box"
	else
	super
	end
	end

.

@keithdoggett I don't see any work in rgeo-activerecord around SRID. Given someone else has submitted a similar PR is there something either of us can do to aid in review (e.g. if you prefer the specs in the other PR)? Thanks

[inkstak]

You'll find a detailled issue at #429
Also #431 seems to be related.

[nikolai-b]

Thanks you. I've included your spec as it now works, is that ok as it is your code?

Sadly #431 is not fixed by this change

[BuonOmo]

Sorry I show up super late, but I just figured out that we have a similar thing happening in the CRDB adapter, and there the fix is made in the #quote method. I was wondering which one is the more appropriate. I could have a look myself at some point, not sure when though.

https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/e27240ed43300946e8e535c291413f9b5c771c0a/lib/active_record/connection_adapters/cockroachdb/quoting.rb#L46