Skip to content

Conversation

@zzambers
Copy link

@zzambers zzambers commented Dec 9, 2025

Update scala version to 2.13.18 to support JDK26.

@zzambers
Copy link
Author

zzambers commented Dec 9, 2025

Hmm, looking at code this does not seem to do anything apart from changing dir name for cloned repo. Also repo is not upstream one but https://github.com/judovana/scala.git. Not sure why.

Edit: Oh, it uses custom branch with some workarounds. We will probably need to rabase that...

Edit2: Nevermind, I see that changes made it to upstream, I'll update the PR to use upstream then.

@zzambers zzambers marked this pull request as draft December 9, 2025 19:13
@zzambers zzambers marked this pull request as ready for review December 9, 2025 19:32
Copy link

@andrlos andrlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@zzambers
Copy link
Author

zzambers commented Dec 9, 2025

btw. Someone else will need to merge this. I don't have permission in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants