Skip to content

Conversation

@deepika-vr
Copy link

@deepika-vr deepika-vr changed the title Update all old style promises to async/await Updated all old style promises to async/await Dec 2, 2025
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more fix needed:

test/common/static-code
not ok 1 /static-code/test-eslint
# 
# /work/make-checkout-workdir/build.js
#   37:37  error  Avoid callbacks. Prefer Async/Await  promise/prefer-await-to-callbacks
# 
# ✖ 1 problem (1 error, 0 warnings)
WARNING: skipping /static-code/test-typescript: no tsc

@KKoukiou
Copy link
Contributor

KKoukiou commented Dec 5, 2025

Please squash the commits and remove the test/reference change from your commit, you incorrectly put it there, assumingly by running git add -u

fixed eslint issues

fixed eslint issue on build.js
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we added more:

not ok 1 /static-code/test-eslint
# 
# /work/make-checkout-workdir/build.js
#   36:1  error  Expected indentation of 4 spaces but found 0  indent
# 
# /work/make-checkout-workdir/src/apis/payload_dnf.js
#   39:7  error  Prefer await to then()/catch()/finally()  promise/prefer-await-to-then
# 
# ✖ 2 problems (2 errors, 0 warnings)
#   1 error and 0 warnings potentially fixable with the `--fix` option.
WARNING: skipping /static-code/test-typescript: no tsc
make: *** [Makefile:194: codecheck] Error 1

*** Failure: Container exited with code 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants