-
Notifications
You must be signed in to change notification settings - Fork 30
Enhance frontend exception reporting #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf15c5c to
2ffe381
Compare
2ffe381 to
a300c05
Compare
2b916ff to
2b12351
Compare
2b12351 to
c0902c2
Compare
c0902c2 to
a52d189
Compare
|
@bruno-fs Obviously after holiday - I would appreciate a second look. |
|
Looks good! My only concern is if the stacktrace is too big and the url size exceeds the size allowed by the browser - or if bugzilla has some size limitation as well. |
Good point, I will investigate the current limitations. |
|
I need to rebase this |
a52d189 to
18412f0
Compare
- Simplify getDerivedStateFromError to only set error flag to avoid overwriting front end exceptions as backend ones - Remove redundant componentDidCatch method - Combine window.onerror and window.onunhandledexception handlers
Frontend tracebacks shown in Bugzilla lacked source maps, as window.onerror does not display errors with applied source maps. To address this, integrate the stacktrace-js library to improve the readability of reported frontend exceptions.
18412f0 to
5e63ffd
Compare
Frontend tracebacks shown in Bugzilla lacked source maps, as window.onerror does not display errors with applied source maps. To address this, integrate the stacktrace-js library to improve the readability of reported frontend exceptions.
With this commit we have proper tracebacks: