Skip to content

Conversation

@Maybach91
Copy link

A value for the hidden attribute is not allowed, so we don’t need to set it.

Current Behaviour:
rv-show="foobar will render style="display: none;" hidden="true"

Expected Behaviour for valid HTML:
rv-show="foobar will render style="display: none;" hidden

References:
https://html.spec.whatwg.org/multipage/interaction.html#the-hidden-attribute
https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attribute

Consider also adding/using aria-hidden values, but this would be a feature.

A value for the `hidden` attribute is not allowed, so we don’t need to set it.
Copilot AI review requested due to automatic review settings June 13, 2025 09:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the hidden attribute is rendered correctly as a boolean attribute (without a value) when rv-show is false.

  • Remove use of "true" value on hidden attribute
  • Use bare hidden presence for valid HTML

@Maybach91
Copy link
Author

@JumpLink

@JumpLink
Copy link

JumpLink commented Jun 16, 2025

@Maybach91 Thank you, I will publish a new release for this :)

@JumpLink JumpLink merged commit e4b4b08 into ribajs:main Jun 16, 2025
3 checks passed
@JumpLink
Copy link

@Maybach91 I'm just waiting to see if #40 goes through.

@Maybach91
Copy link
Author

Nice, thanks @JumpLink !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants