Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified name of node file when autogenerating node attribute #126

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Modified name of node file when autogenerating node attribute #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed
- Name of node file changed to not mention name of autogenerated attribute (in order to make filename shorter)


## [2.0.0-rc8] - 2024-10-26

Expand Down
7 changes: 6 additions & 1 deletion src/qgis_conefor/processing/algorithms/coneforinputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,18 @@ def _generate_node_file_by_attribute(
start_progress: int,
progress_step: float,
) -> Path:
node_attribute_fragment = (
node_attribute_field
if node_attribute_field != self._autogenerated_node_attribute_field_name
else "calculated_area"
)
return coneforinputsprocessor.generate_node_file_by_attribute(
node_id_field_name=node_id_field,
node_attribute_field_name=node_attribute_field,
nodes_to_add_field_name=nodes_to_add_field,
feature_iterator_factory=source.getFeatures,
output_path=(
output_dir / f"nodes_{node_attribute_field}_{filename_fragment}.txt"
output_dir / f"nodes_{node_attribute_fragment}_{filename_fragment}.txt"
),
progress_callback=feedback.setProgress,
start_progress=start_progress,
Expand Down