Adding GitHub checks #7
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gitstart
force-pushed
the
adding-github-checks
branch
from
9b7e773
to
cee2f4c
Compare
|
Hi @richardguerre this pr is ready for review. NB: The backend tests is failing and stuck in a loop . You can create a separate ticket for that if you would like us to fix that. |
Co-authored-by: MayanjaAndrew <[email protected]>
gitstart
force-pushed
the
adding-github-checks
branch
from
52c2154
to
a282907
Compare
.github/actions/setup/action.yml
Outdated
| inputs: | ||
| ssh-private-key: | ||
| description: "SSH key used for private git clone" | ||
| required: true |
There was a problem hiding this comment.
What is this for? The GitHub actions seem to work fine without any "input".
There was a problem hiding this comment.
Yeah. It's not needed. We'll remove it.
.github/actions/setup/action.yml
Outdated
| - name: Use Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18.13.0" |
There was a problem hiding this comment.
Check the version in .nvmrc or even try and use the version in .nvmrc using cat .nvmrc. This issue seems to point out how to do it.
.github/workflows/checks.yml
Outdated
| - name: Prisma Gen | ||
| run: npm run gen -w apps/server | ||
| - name: Test check | ||
| run: npm run test -w apps/server |
There was a problem hiding this comment.
The reason this check is in a loop is because vitest runs in watch mode in a development environment and in run mode when process.env.CI is truthy. Normally GitHub actions already insert CI=true as part of environment variables. You can try adding manually right below the DATABASE_URL env.
|
Also why was this not done as part of #2? Can you try not to create duplicate PRs? |
- Prisma gen doesn't migrate the DB with the latest tables which might be why the tests were stuck in an infinite loop. - Check if using `npm run db:dev` instead of `gen -w apps/server` works by running `Item.test.ts`
CLoses out issue: FLOW-GS-2