Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: uninstall key add DisplayIcon #1311

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

3gf8jv4dv
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv commented Jun 14, 2024

Display the software’s own icon in the uninstall entry in Control Panel\Programs\Programs and Features instead of the boring system icon.

@3gf8jv4dv 3gf8jv4dv changed the title installer: uninstall key add DisplayName installer: uninstall key add DisplayIcon Jun 14, 2024
@3gf8jv4dv 3gf8jv4dv force-pushed the installer-uninstall-key-icon branch from 84792e4 to ed0b185 Compare June 14, 2024 15:12
@fxliang
Copy link
Contributor

fxliang commented Jun 15, 2024

WriteRegStr HKLM "${REG_UNINST_KEY}" "DisplayVersion" "${WEASEL_VERSION}.${WEASEL_BUILD}"

主要修改是增加了这个,是吗?

@3gf8jv4dv
Copy link
Contributor Author

3gf8jv4dv commented Jun 15, 2024

WriteRegStr HKLM "${REG_UNINST_KEY}" "DisplayVersion" "${WEASEL_VERSION}.${WEASEL_BUILD}"

主要修改是增加了这个,是吗?

No. Added is DisplayIcon. This key did not exist before.

WriteRegStr HKLM "${REG_UNINST_KEY}" "DisplayIcon" '"$INSTDIR\WeaselServer.exe"'

There were two consecutive half-width spaces in the middle of several other lines, which I changed to one. Like this:

- WriteRegStr HKLM "${REG_UNINST_KEY}"  "Publisher" "式恕堂"
+ WriteRegStr HKLM "${REG_UNINST_KEY}" "Publisher" "式恕堂"

@fxliang fxliang merged commit 8621ed2 into rime:master Jun 15, 2024
1 check passed
@3gf8jv4dv 3gf8jv4dv deleted the installer-uninstall-key-icon branch June 15, 2024 13:12
fxliang pushed a commit to fxliang/weasel that referenced this pull request Jun 18, 2024
wxyzh pushed a commit to wxyzh/weasel that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants