error: add io::Error conversion#12
Merged
ririsoft merged 2 commits intoririsoft:masterfrom Jan 27, 2025
tharvik:master
Merged
Conversation
Ensure we keep test coverage to 90%.
Owner
|
I am so sorry I missed your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accessing the contained io::Error solely via a ref is a bit bothering to work with.
this PR takes from sync walkdir's
Errorallowing to extract the underlyingio::Error.into_ioto extract the containedio::ErrorFrom<Error> for io::Errorto create a more "classic" error typenote: I choose to name it
into_io()to be consistant withio(), in contrario to upstream postfix theses with "_error".