Permit underscores after single-letter extensions#198
Open
Wren6991 wants to merge 1 commit intoriscv-software-src:devfrom
Open
Permit underscores after single-letter extensions#198Wren6991 wants to merge 1 commit intoriscv-software-src:devfrom
Wren6991 wants to merge 1 commit intoriscv-software-src:devfrom
Conversation
Signed-off-by: Luke Wren <wren6991@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec permits optional underscores between single-letter extensions, and before the first Z extension. Reference is here: https://github.com/riscv/riscv-isa-manual/blob/main/src/naming.adoc#underscores
However the regex used in
riscv-configrejects these underscores. This was raised already in #151. This patch updates the regex to permit underscores in these locations.