Skip to content

Fixed typo in constants.py #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgiatai wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fixed typo in constants.py #199

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
652e964
Fixed typo in constants.py
georgiatai Jun 10, 2025
1aabed7
Added Zvl2048b for Zvl extensions
georgiatai Jun 13, 2025
7443f84
Added Zvl4096b
georgiatai Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion riscv_config/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
platform_schema = os.path.join(root, 'schemas/schema_platform.yaml')
custom_schema = os.path.join(root, 'schemas/schema_custom.yaml')
Zvl_extensions = [
"Zvl32b", "Zvl64b", "Zvl128b", "Zvl256b", "Zve512b", "Zvl1024b"
"Zvl32b", "Zvl64b", "Zvl128b", "Zvl256b", "Zvl512b", "Zvl1024b", "Zvl2048b"
Copy link

@jordancarlin jordancarlin Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like Zvl2048b is an actual extension. From the "Zvl*: Minimum Vector Length Standard Extensions" section of the spec:

image

Copy link
Author

@georgiatai georgiatai Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spike is, however, configured with Zvl*, including Zvl2048b. If it is not included here, then when using riscof, we will be unable to configure with that VLEN. Should Zvl2048b still be included in here in this case, despite not being on the Table 60?

Copy link
Author

@georgiatai georgiatai Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a quote from the spec:

Longer vector length extensions should follow the same pattern.

Thus I think it would be fine to include longer Zvl extensions, and beneficial to match spike.

]
Zvef_extensions = [
"Zve32f", "Zve64f"
Expand Down