Skip to content

release/v1.1.1#2

Merged
melbasiouny-riverside merged 7 commits intomicrohammerfrom
release/v1.1.1
Mar 11, 2026
Merged

release/v1.1.1#2
melbasiouny-riverside merged 7 commits intomicrohammerfrom
release/v1.1.1

Conversation

@melbasiouny-riverside
Copy link
Copy Markdown
Collaborator

@melbasiouny-riverside melbasiouny-riverside commented Mar 10, 2026

  • Add scons uninstall target
  • Drop version suffix from installed .so files
  • Add variant=microhammer to pkg-config metadata
  • Fix crashing scons test from misaligned backend names after pruned backends
  • Improve h_in/h_not_in docs in hammer.h
  • Add GitHub Actions pipeline (clang-format, scons test, .deb build) on PR and manual trigger

@melbasiouny-riverside melbasiouny-riverside self-assigned this Mar 10, 2026
@melbasiouny-riverside melbasiouny-riverside added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 10, 2026
@melbasiouny-riverside melbasiouny-riverside changed the title Release/v1.1.1 release/v1.1.1 Mar 10, 2026
Copy link
Copy Markdown
Collaborator

@GJames-RiversideResearch GJames-RiversideResearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the one comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the v1.1.1 release of libmicrohammer, incorporating an scons uninstall target, a fix for crashing scons test due to misaligned backend names, improved documentation for h_in/h_not_in, and a new GitHub Actions CI pipeline that runs formatting checks, tests, and .deb builds.

Changes:

  • Fix HParserBackendNames in benchmark.c to match the pruned backend enum (only Invalid and Packrat remain)
  • Improve h_in, h_not_in, and several other parser docstrings in hammer.h
  • Add a multi-job GitHub Actions pipeline (clang-format, scons test, .deb build), replacing the pre-commit hook approach

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/t_bitreader.c Reformats MK_INPUT_STREAM macro to comply with clang-format
src/hammer.h Improves docstrings for h_in, h_not_in, h_bytes, h_parse_start, and h_length_value
src/benchmark.c Fixes HParserBackendNames array to match the two remaining backends (PB_INVALID, PB_PACKRAT)
debian/changelog Adds v1.1.1 release entry
VERSION Bumps version from 1.1.0 to 1.1.1
DEVELOPMENT.md Drops pre-commit section; retains standalone clang-format instructions
.pre-commit-config.yaml Removes the file (pre-commit hook replaced by GitHub Actions)
.github/workflows/pipeline.yml Adds clang-format and scons-test jobs; expands trigger to include pull_request
Comments suppressed due to low confidence (2)

.github/workflows/pipeline.yml:42

  • The "Create tag" step (visible in the full file) creates a local git tag with git tag $TAG but never pushes it to the remote repository (e.g., with git push origin $TAG). Since every GitHub Actions runner starts with a fresh checkout, the locally created tag is discarded when the job finishes. The contents: write permission suggests the intent was to push the tag. Either add git push origin $TAG after the git tag command, or remove this step entirely if tagging is not intended to happen as part of this workflow.

Additionally, this tag creation step runs on every PR event. Creating version tags on unmerged PRs is generally undesirable and could conflict with the official release tag when the branch is merged.
.github/workflows/pipeline.yml:42

  • The three jobs (clang-format, scons-test, build-deb) run in parallel with no needs: dependency declared. This means the .deb package can be built and tagged even when the clang-format check or scons-test job fails. If the intent is to gate the .deb build on passing tests and formatting checks, add needs: [clang-format, scons-test] to the build-deb job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@melbasiouny-riverside melbasiouny-riverside merged commit 3873ed2 into microhammer Mar 11, 2026
3 checks passed
@melbasiouny-riverside melbasiouny-riverside deleted the release/v1.1.1 branch March 11, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants