Conversation
GJames-RiversideResearch
left a comment
There was a problem hiding this comment.
Looks good besides the one comment
There was a problem hiding this comment.
Pull request overview
This PR prepares the v1.1.1 release of libmicrohammer, incorporating an scons uninstall target, a fix for crashing scons test due to misaligned backend names, improved documentation for h_in/h_not_in, and a new GitHub Actions CI pipeline that runs formatting checks, tests, and .deb builds.
Changes:
- Fix
HParserBackendNamesinbenchmark.cto match the pruned backend enum (onlyInvalidandPackratremain) - Improve
h_in,h_not_in, and several other parser docstrings inhammer.h - Add a multi-job GitHub Actions pipeline (
clang-format,scons test,.debbuild), replacing the pre-commit hook approach
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/t_bitreader.c |
Reformats MK_INPUT_STREAM macro to comply with clang-format |
src/hammer.h |
Improves docstrings for h_in, h_not_in, h_bytes, h_parse_start, and h_length_value |
src/benchmark.c |
Fixes HParserBackendNames array to match the two remaining backends (PB_INVALID, PB_PACKRAT) |
debian/changelog |
Adds v1.1.1 release entry |
VERSION |
Bumps version from 1.1.0 to 1.1.1 |
DEVELOPMENT.md |
Drops pre-commit section; retains standalone clang-format instructions |
.pre-commit-config.yaml |
Removes the file (pre-commit hook replaced by GitHub Actions) |
.github/workflows/pipeline.yml |
Adds clang-format and scons-test jobs; expands trigger to include pull_request |
Comments suppressed due to low confidence (2)
.github/workflows/pipeline.yml:42
- The "Create tag" step (visible in the full file) creates a local git tag with
git tag $TAGbut never pushes it to the remote repository (e.g., withgit push origin $TAG). Since every GitHub Actions runner starts with a fresh checkout, the locally created tag is discarded when the job finishes. Thecontents: writepermission suggests the intent was to push the tag. Either addgit push origin $TAGafter thegit tagcommand, or remove this step entirely if tagging is not intended to happen as part of this workflow.
Additionally, this tag creation step runs on every PR event. Creating version tags on unmerged PRs is generally undesirable and could conflict with the official release tag when the branch is merged.
.github/workflows/pipeline.yml:42
- The three jobs (
clang-format,scons-test,build-deb) run in parallel with noneeds:dependency declared. This means the.debpackage can be built and tagged even when theclang-formatcheck orscons-testjob fails. If the intent is to gate the.debbuild on passing tests and formatting checks, addneeds: [clang-format, scons-test]to thebuild-debjob.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scons uninstalltarget.sofilesvariant=microhammerto pkg-config metadatascons testfrom misaligned backend names after pruned backendsh_in/h_not_indocs inhammer.hclang-format,scons test,.debbuild) on PR and manual trigger