Open
Conversation
rjsmith1999
reviewed
Mar 26, 2026
resolve-cveassert/src/CVEAssert.cpp
Outdated
Comment on lines
+201
to
+202
| uint32_t cwe_id = static_cast<uint32_t>(std::stoi(vuln.WeaknessID)); | ||
| switch (cwe_id) { |
Collaborator
There was a problem hiding this comment.
It looks like "0" is not a valid CWE id...
So, we could not deal with strings and instead use a sentinel value of 0 to indicate "instrument all".
Vulnerability.hpp would parse the appropriate string and convert it to a sentinel integer, which we can then switch on here.
added 4 commits
March 30, 2026 09:36
…arse into uint32 to test if it still works.
elazaro-riverside
force-pushed
the
feature/apply-multiple-sans
branch
from
eedfad3 to
e7774da
Compare
elazaro-riverside
changed the title
rjsmith1999
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.