[PR] Refactoring runOnFunction in CVEAssert#170
Merged
rjsmith1999 merged 11 commits intomainfrom Mar 31, 2026
Merged
Conversation
…after I tried to fix a space but I am putting it back now.
elazaro-riverside
force-pushed
the
refactoring-cve-assert
branch
from
46eba94 to
865d3c5
Compare
rjsmith1999
approved these changes
Mar 31, 2026
resolve-cveassert/src/CVEAssert.cpp
Outdated
Comment on lines
+114
to
+118
| void dumpIR(Function &F, raw_ostream &out, const std::string msg = "") { | ||
| out << msg; | ||
| out << F; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Should we put this function adjacent to the verifyIR function?
Its possible you could make them be the same function by adding another optional parameter bool verify
resolve-cveassert/src/CVEAssert.cpp
Outdated
Comment on lines
+107
to
+112
| bool matchRemediationStrategy(Vulnerability &vuln) { | ||
| if (vuln.Strategy == Vulnerability::RemediationStrategies::NONE) { | ||
| return true; | ||
| } | ||
| return false; | ||
| } |
Collaborator
There was a problem hiding this comment.
This function in its current form is less readable than the vuln.Strategy == Vulnerability::RemediationStrategies::NONE condition it replaces?
If we don't use it more than once, I would leave this inline in the original function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.