Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Conversation

@jog1t
Copy link
Collaborator

@jog1t jog1t commented Jun 18, 2025

No description provided.

Copy link
Collaborator Author

jog1t commented Jun 18, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry changed the base branch from 06-17-chore_rename_app_-_registry_ to graphite-base/992 June 19, 2025 18:11
@jog1t jog1t force-pushed the 06-19-feat_sqlite branch from cec0ae4 to de1a8d5 Compare June 19, 2025 21:42
@jog1t jog1t force-pushed the graphite-base/992 branch from 0a8dd91 to af5e352 Compare June 19, 2025 21:42
@jog1t jog1t changed the base branch from graphite-base/992 to 06-11-refactor_react_0.9 June 19, 2025 21:42
@NathanFlurry NathanFlurry changed the base branch from 06-11-refactor_react_0.9 to graphite-base/992 June 20, 2025 00:09
@jog1t jog1t force-pushed the 06-19-feat_sqlite branch from de1a8d5 to c3197fc Compare June 20, 2025 00:12
@jog1t jog1t changed the base branch from graphite-base/992 to 06-11-refactor_react_0.9 June 20, 2025 00:13
@NathanFlurry NathanFlurry changed the base branch from 06-11-refactor_react_0.9 to graphite-base/992 June 20, 2025 01:02
@jog1t jog1t force-pushed the 06-19-feat_sqlite branch from c3197fc to 4512d9d Compare June 23, 2025 18:56
Comment on lines +1 to +3
# Hono Integration for RivetKit

Example project demonstrating Hono web framework integration with [RivetKit](https://rivetkit.org).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README title and description in the drizzle example incorrectly identifies this as a "Hono Integration" example when it's actually demonstrating SQLite/Drizzle database integration with RivetKit. The title and description should be updated to accurately reflect the content of this example, which appears to be focused on database integration rather than the Hono web framework.

Suggested change
# Hono Integration for RivetKit
Example project demonstrating Hono web framework integration with [RivetKit](https://rivetkit.org).
# Drizzle SQLite Integration for RivetKit
Example project demonstrating SQLite database integration with [RivetKit](https://rivetkit.org) using Drizzle ORM.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.


```sh
git clone https://github.com/rivet-gg/rivetkit
cd rivetkit/examples/hono
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README in the drizzle example directory contains an incorrect installation path. It instructs users to cd rivetkit/examples/hono when it should be cd rivetkit/examples/drizzle since this is the drizzle example directory.

Suggested change
cd rivetkit/examples/hono
cd rivetkit/examples/drizzle

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

npm run dev
```

Open your browser to http://localhost:3000 to see the Hono server with RivetKit integration.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README in the drizzle example references a Hono server and instructs users to open http://localhost:3000, but this appears to be copied from a different example. The drizzle/SQLite example likely doesn't have a web interface or uses a different port. Consider updating the README with instructions specific to this database example.

Suggested change
Open your browser to http://localhost:3000 to see the Hono server with RivetKit integration.
After running the example, you can interact with the SQLite database through the provided scripts or commands. Check the console output for any specific instructions.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@jog1t jog1t force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch from 69062e3 to f18a638 Compare June 26, 2025 19:27
@jog1t jog1t force-pushed the 06-19-feat_sqlite branch from 5e205cf to 8698042 Compare June 26, 2025 19:27
@jog1t jog1t mentioned this pull request Jun 26, 2025
@NathanFlurry NathanFlurry force-pushed the 06-24-chore_add_rivet_as_a_default_driver branch from f18a638 to 69062e3 Compare June 27, 2025 08:43
@graphite-app
Copy link

graphite-app bot commented Jun 27, 2025

Merge activity

  • Jun 27, 8:53 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 27, 8:55 AM UTC: CI is running for this pull request on a draft pull request (#1030) due to your merge queue CI optimization settings.
  • Jun 27, 8:56 AM UTC: Merged by the Graphite merge queue via draft PR: #1030.

graphite-app bot pushed a commit that referenced this pull request Jun 27, 2025
@graphite-app graphite-app bot closed this Jun 27, 2025
@graphite-app graphite-app bot deleted the 06-19-feat_sqlite branch June 27, 2025 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant