Skip to content

add README note for "ImportError: DLL load failed" #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiang7369
Copy link

I encountered this problem when trying to start a background project using ginza.

After exploring(ginza->SudachiPy->darts-clone), I found that this package has a dll error.

I don't know what dll is missing, I installed the latest supported Visual C++ redistributable packages with a try mentality and solved the problem. I think we can add a note for it in README.md.

@rixwew
Copy link
Owner

rixwew commented Mar 20, 2020

Could you tell me your os and python version to reproduce the error?
Thank you @jiang7369 for reporting the problem.

@jiang7369
Copy link
Author

os: Windows10
python: 3.6.8

But this may have nothing to do with the version. Windows 10 without the VC++ package can reproduce it, I think.

@rixwew
Copy link
Owner

rixwew commented Mar 22, 2020

Thank you @jiang7369
I reproduced it and confirmed that bundling some vc++ dll like pandas solve the error.
pandas-dev/pandas#21321

We should decide whether to bundle vc++ dll or not.
I'd like to get your thoughts on this issue. @hiroshi-matsuda-rit @toshi-saito

@hiroshi-matsuda-rit
Copy link
Collaborator

hiroshi-matsuda-rit commented Mar 24, 2020

@jiang7369 @rixwew Thanks for reporting.
In fact, I've never encountered this error while installing GiNZA on some of the Windows 10 environments.
But we should solve this error with the work around of pandas, I think.
Please check the license of the DLL files to be added to the whl packages and make sure that the license is compatible with darts-clone-python's one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants