Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph widget - do not print basic block address - Fixed #3154

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

M-ismail-ramzan
Copy link

Your checklist for this pull request

Detailed description
We encountered an issue when attempting to use the "Show offset for each instruction" feature after clicking "Edit" -> "Preferences". The problem was that it wasn't working as expected. To fix it, I made changes to the code by replacing the API call from "graph.offset" to "asm.offset" and updating other related code accordingly.

Test plan (required)
Before, the button had no effect. Now, it works properly as expected. Below are images of the functioning featureimage
image

Closing issues
This pull request closes issue #3144.

@karliss
Copy link
Member

karliss commented Mar 30, 2023

Now it will probably conflict with the setting for linear disassembly view.

@ITAYC0HEN
Copy link
Member

Thanks for the PR @M-ismail-ramzan, indeed I experience the same bug. That said, the proposed solution approaches it in the wrong direction as this changes the displaying of the offset across all widgets and not only in graph. The solution should be either in the graph view, in case it does not respect the configuration value, or in Rizin, in case it does not honor this config value when providing the graph response to Cutter.

@karliss you probably know which of these causes the issue 🤭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants