Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grammar: Remove prec.right from tmp_*_op rules #4846

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 17, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr removes prec.right from the tmp_*_op rules in subprojects/rizin-shell-parser/grammar.js since after #4826, they are apparently not needed anymore, and tree-sitter isn't complaining about parsing ambiguity after their removal.

Test plan

All builds are green.

Closing issues

...

@kazarmy kazarmy requested a review from ret2libc as a code owner January 17, 2025 11:23
@kazarmy kazarmy requested review from wargio and Rot127 January 17, 2025 11:24
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ret2libc please give it a look

@kazarmy kazarmy merged commit cf6488f into rizinorg:dev Jan 17, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants