Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Use blue dot for nonprintable chars #4885

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Feb 7, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

This pr addresses the problem in #4880 (comment) by making search use a blue dot for nonprintable characters in search results, if colors are enabled. Example below:

Before After
lib_search_blue_dot_before lib_search_blue_dot_after

Test plan

The change makes sense. All builds are green.

Closing issues

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant