Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development version #36

Draft
wants to merge 505 commits into
base: master
Choose a base branch
from
Draft

Merge development version #36

wants to merge 505 commits into from

Conversation

Bachibouzouk
Copy link
Contributor

No description provided.

hacra added 30 commits July 7, 2023 14:13
Copy link
Contributor Author

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the container name

context: ./fastapi_app # ./flask_app #
dockerfile: Dockerfile
app:
container_name: 'app'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'app'
container_name: 'pps_app'

worker:
- mysql
mysql:
container_name: mysql
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: mysql
container_name: pps_mysql

- ./db_data/user_db:/var/lib/mysql
redis:
image: redis
container_name: 'redis'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'redis'
container_name: 'pps_redis'

ports:
- '40005:6379'
worker_default:
container_name: 'celery_default'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'celery_default'
container_name: 'pps_celery_default'

- pw
worker_milp:
container_name: 'celery_milp'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'celery_milp'
container_name: 'pps_celery_milp'

- pw
flower:
container_name: 'flower'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'flower'
container_name: 'pps_flower'

- pw
adminer:
container_name: 'adminer'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'adminer'
container_name: 'pps_adminer'

- pw
db_initializer:
container_name: 'db_initializer'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_name: 'db_initializer'
container_name: 'pps_db_initializer'

self.start_datetime = pd.to_datetime(self.project_setup["start_date"]).to_pydatetime()
# self.start_datetime = pd.to_datetime(self.project_setup["start_date"]).to_pydatetime()
# start_datetime hardcoded as only 2022 pv and demand data is available
self.start_datetime = pd.to_datetime('2022').to_pydatetime()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ha-cra
What will then happen if the data gets updated? What would be the best way of remembering such an hardcoded fix?

@GregoryIreland - do you have suggestions? This conversation has a link that can be put in some report file or a github issue for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants