Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts #1

SourceryAI · 2023-02-20T14:22:23Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/django-admin-shortcuts master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2023-02-20T14:22:25Z

admin_shortcuts/templatetags/admin_shortcuts_tags.py

-            if 'request' in args:
-                result = result(request)
-            else:
-                result = result()
+            result = result(request) if 'request' in args else result()


Function eval_func refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2023-02-20T14:22:25Z

admin_shortcuts/templatetags/admin_shortcuts_tags.py

-    for key, value in CLASS_MAPPINGS:
-        if key is not None and key in url:
-            return value
-    return 'config' # default icon
+    return next(
+        (
+            value
+            for key, value in CLASS_MAPPINGS
+            if key is not None and key in url
+        ),
+        'config',
+    )


Function get_shortcut_class refactored with the following changes:

Use the built-in function next instead of a for-loop (use-next)

This removes the following comments ( why? ):

# default icon

'Refactored by Sourcery'

2534c28

SourceryAI commented Feb 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts #1

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts #1

SourceryAI commented Feb 20, 2023

SourceryAI Feb 20, 2023

SourceryAI Feb 20, 2023

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts #1

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored rlclaro/django-admin-shortcuts #1

Conversation

SourceryAI commented Feb 20, 2023

SourceryAI Feb 20, 2023

Choose a reason for hiding this comment

SourceryAI Feb 20, 2023

Choose a reason for hiding this comment