Add WildStacker Barrel support#1171
Conversation
| <id>rlf-mvn-repo</id> | ||
| <url>https://raw.github.com/rlf/mvn-repo/master/</url> | ||
| </repository> | ||
| <repository> |
There was a problem hiding this comment.
I'd rather not use local file repositories in Maven. Another issue at the moment is that anyone who hasn't bought the plugin is unable to build uSkyBlock with this dependency. It would be nice if the WildStacker developer releases a public API package to use as dependency.
We can use the rlf-mvn-repo repository on Github if necessary when WildStacker doesn't offer a repository.
There was a problem hiding this comment.
The WildStack Api is free. https://www.spigotmc.org/threads/wildstackerapi-api-for-wildstacker-2.338775/
I can remove the local repository, because I changed the dependency
|
In some days I will although add Wildstacker spawner support and EpicSpawner support |
rlf
left a comment
There was a problem hiding this comment.
First off, don't use systempath, it only works on your machine. Find a maven repo that has it, or put it in your own repo.
2nd, use maven shading when relying on 3rd party code, otherwise your plugin will fail if other plugins include the same plugin in a different version.
3rd why add the location, when you have the region? And why not use the existing logic to get score based on block type?
|
I tryed to add WildStacker barrel support for the score generation, but I can't test It, because I don't know how to compile the plugin in IDEA.