Make nether island region heights configurable#1176
Open
addstar wants to merge 1 commit intorlf:masterfrom
Open
Make nether island region heights configurable#1176addstar wants to merge 1 commit intorlf:masterfrom
addstar wants to merge 1 commit intorlf:masterfrom
Conversation
Collaborator
|
Thanks for your PR! Sounds like a good idea to make this configurable, but I'm not sure if we want the user to directly control the setY() calls via the config option. It might create cases where users put in impossible values. Another thing we need to check is if/how the user can recreate the WorldGuard regions (protectall?) after changing this settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1172, the nether region height was inadvertently adjusted a while ago. And although it's now fixed in master, I thought it would be good to have this configurable.
Server owners can now set
minYandmaxYfor the island regions created in the nether.The default values in config (and code) are now: